Address PR review comments: type safety, error sanitization, and testing#73
Merged
Merged
Conversation
…error sanitization - Fix type from UpdateRecord to UpdateMultipleRecord in update_multiple - Fix type from u32 to u64 for max_records parameter - Update default API version from 62.0 to 65.0 (sf-wasm-types and example) - Use Arc<str> for access_token and instance_url to reduce memory copies - Sanitize error codes instead of exposing Debug format to WASM guests - Update security documentation to clarify SOQL injection responsibility Co-authored-by: jlantz <1697127+jlantz@users.noreply.github.com>
… sf-guest-sdk - Add integration tests for sf-bridge (module loading, WASM validation) - Document why unit tests aren't feasible for sf-guest-sdk (requires Extism runtime) - Explain that guest SDK is tested via bridge integration tests and examples - Add busbar-sf-bridge to dev-dependencies for integration tests Co-authored-by: jlantz <1697127+jlantz@users.noreply.github.com>
- Make invalid WASM test assertion specific (expect rejection at construction) - Move testing strategy documentation to module-level doc comment for visibility - Remove duplicate testing notes at end of sf-guest-sdk file Co-authored-by: jlantz <1697127+jlantz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add WASM bridge for sandboxed Salesforce API access
Address PR review comments: type safety, error sanitization, and testing
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all review comments from PR #71 on the WASM bridge implementation.
Type Safety
UpdateRecord→UpdateMultipleRecordinupdate_multiplesignatureu32→u64formax_recordsparameter to match bridge type definitionsSecurity & Memory
Arc<str>instead ofStringforaccess_tokenandinstance_urlfields to reduce credential duplication in memoryAUTH_ERROR,HTTP_500,RATE_LIMITED) instead of exposing Debug formatDocumentation & Testing
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.