Add new Feature: sending files directly to the downloads folder.#106
Open
nidhal-labidi wants to merge 1 commit intofeat/add-cleanup-mechanism-for-old-db-entriesfrom
Open
Add new Feature: sending files directly to the downloads folder.#106nidhal-labidi wants to merge 1 commit intofeat/add-cleanup-mechanism-for-old-db-entriesfrom
nidhal-labidi wants to merge 1 commit intofeat/add-cleanup-mechanism-for-old-db-entriesfrom
Conversation
… the primary device Signed-off-by: nidhal-labidi <nidhal.labidi@compose.us>
nidhal-labidi
changed the base branch from
main
to
feat/add-cleanup-mechanism-for-old-db-entries
Narigo
requested changes
Jan 14, 2025
Member
Narigo
left a comment
Narigo
left a comment
There was a problem hiding this comment.
Nice to see this!
As discussed, we can have some improvements to it
| <div class="min-h-screen flex items-center justify-center overflow-hidden bg-gray-50"> | ||
| <div class="max-w-screen-xl w-full p-4 box-border flex flex-col items-center"> | ||
| <h1 class="text-2xl font-bold text-gray-800 mb-8">Remote File Drop</h1> | ||
|
|
Member
There was a problem hiding this comment.
Would be nice to add links to the individual files here as a list instead of starting a download of them directly - this allows users to change file names and the folder when they save it.
Comment on lines
+67
to
+74
| const url = window.URL.createObjectURL(receivedFile); | ||
| const a = document.createElement('a'); | ||
| a.href = url; | ||
| a.download = receivedFile.name; | ||
| document.body.appendChild(a); | ||
| a.click(); | ||
| document.body.removeChild(a); | ||
| window.URL.revokeObjectURL(url); |
Member
There was a problem hiding this comment.
This could be put this into links for downloading
Comment on lines
+5
to
+9
| let createWebRtcChannel: () => void; | ||
| let connectionStatus = 'new'; | ||
| let connectionInfo = { link: '', qrCode: '' }; | ||
| let progress = { currentFileNumber: 0, totalNumberOfFiles: 0, currentFileName: '' }; | ||
| let error = ''; |
Comment on lines
+106
to
+108
| {/if} | ||
|
|
||
| {#if connectionStatus === 'endpoint-created'} |
Member
There was a problem hiding this comment.
All of these could be turned into {:else if connectionStatus === '...'}, so it's easier to see these parts are never shown at the same time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Reviewer
Changes
Check #105