Conversation
The differential fuzzer was failing in CI because tar-core correctly rejects malformed PAX extension records while tar-rs silently skips them (via .flatten()). This is an intentional strictness difference, not a bug. Add a structured allowlist of known behavioral divergences between tar-core and tar-rs. When tar-core parses fewer entries than tar-rs, we check whether the terminal error falls into an allowlisted category before failing the test. Entries that were successfully parsed by both sides are still compared for correctness. To support this, add parse_tar_core_detailed() to testutil which returns both the parsed entries and any terminal ParseError, rather than silently discarding the error. Fixes: https://github.com/cgwalters/tar-core/actions/runs/22591594816 Assisted-by: OpenCode (Claude claude-opus-4-6)
The sans-IO parser returns NeedData when given insufficient input, and callers must retry with more bytes. Previously, fuzz targets always passed the entire remaining input, so the NeedData/retry path was only exercised at the very end of truncated inputs. Now both targets feed the parser through a variable-sized window: each parse call gets a fresh chunk size (1 byte to 1 MiB) from a seeded SmallRng, simulating the non-uniform read patterns that real I/O produces. On NeedData the window grows to the requested minimum to guarantee forward progress. Assisted-by: OpenCode (Claude claude-opus-4-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.