Fixes issue when role name (group title) contains whitespaces#4
Open
KBenas wants to merge 1 commit intocomputer-lab:masterfrom
Open
Fixes issue when role name (group title) contains whitespaces#4KBenas wants to merge 1 commit intocomputer-lab:masterfrom
KBenas wants to merge 1 commit intocomputer-lab:masterfrom
Conversation
r1b
requested changes
Feb 6, 2018
Contributor
r1b
left a comment
r1b
left a comment
There was a problem hiding this comment.
Thanks for this! A few suggestions:
-
Could you apply the formatting to the group here where the group names are retrieved? Perhaps create a function like
_format_group_nameand give it eachgroup.name. -
Could the formatting handle all types of whitespace and not just space?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.