Feat: no useQuads update#134
Open
jitsedesmet wants to merge 5 commits into
Open
Conversation
…xtures - Remove error throw in translateInsertDelete when useQuads is false - Handle WITH clause correctly: use GRAPH algebra node when useQuads is false instead of recurseGraph which pushes into quad patterns - Update test-utils algebraGenerators to yield both quads: false and quads: true variants based on fixture existence - Update algebra.test.ts consumers to use test.quads from generator - Update generateJson.test.ts to generate both quads variants per query - Remove 141 duplicate -quads.sparql files from sparql statics dir (SPARQL queries are identical regardless of quads setting) - Add non-quads algebra/canonical-sparql fixtures for all update tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@rubensworks Maybe we should release this as V1.2.0? |
Member
|
I would recommend first implementing the changes in comunica as well. These kind of changes always have a chance of requiring other unforeseen changes which are discovered during implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.