fix: address lint errors in sparqlCodepointEscape#143
Draft
jitsedesmet wants to merge 1 commit into
Draft
Conversation
- Use codePointAt() instead of charCodeAt() per unicorn/prefer-code-point - Move inline comments to separate lines per line-comment-position rule - Shorten long test line per max-len rule - Add unterminated short-string test to maintain 100% branch coverage Note: The 5 failing W3C live tests (codepoint-esc-01/02/06/07/08) are old positive tests that PR #346 explicitly removes from the manifest. Implementing PR #346's restriction on codepoint escape placement is inherently incompatible with those old tests; they will be dropped when the PR is merged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The 5 failing W3C live tests (codepoint-esc-01/02/06/07/08) are old positive tests that PR #346 explicitly removes from the manifest. Implementing PR #346's restriction on codepoint escape placement is inherently incompatible with those old tests; they will be dropped when the PR is merged.