Resolve deprecations in Symfony 4.x #123#124
Open
thelem wants to merge 17 commits intocomur:masterfrom
Open
Conversation
added 5 commits
May 9, 2020 21:42
Minimum twig version increased to match Symfony 3.4 and ensure the apply tag is available
The old version has been deprecated
added 2 commits
May 10, 2020 16:17
Register the controller as a service with autowiring
added 2 commits
January 10, 2021 14:49
…#123 As documented in UPGRADE-4.2.md. Minimum Symfony version raised from 3.4 to 4.2. Explict dependency added for symfony/translation.
Interface was introduced on twig 1.23. Required for twig 2/3.
This was causing an exception under my Symfony 5.4 project with session headers being changed after the response had been sent.
Remove JMS translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.