Open
Conversation
conan513
pushed a commit
that referenced
this pull request
Aug 22, 2018
* New register model * Repeat events instead of scheduling them * More proper timers for spells * Added unique names for enums * Added comment for script name * Added missing emote * Added missing Frenzy spell * Cleanup texts (keep only actually used) * Use combat texts * Add ResetAllThreat component to Thundercrash spell script
* New register model * Repeat events instead of scheduling them * Added unique names for enums * Added comments for script names * Added AI for Mana Fiend * Added missing emote * Use all emotes * Create master-script to summon Mana Fiends * Implement & use Zero Mana/Full Health spell * Implement Energize script to end stoned phase * Implement Drain Mana master spell script with correct amount of targets and checks to ensure only players and mana-users will be targeted * Implement Drain Mana visual effect * Now, once all Mana Fiends are dead, stone phase is finished * Rework the way stone phase is started and finished * Moam now drops obsidian mineral once dead * Added a check to ensure all combat spells will be used * Added event to handle Arcane Eruption instead of trying to cast it every update tick Credit for a lot of things goes to CMaNGOS
Credit for a lot of things goes to CMaNGOS
Partially based on CMaNGOS script
(cherry picked from commit 4370f2f)
* Many changes to improve several encounters Credit for a lot of things goes to CMaNGOS Garr fully based on CMaNGOS version
…d on active account expansion Closes #21238
…to allow ignoring most target checks (mostly the default DBC ones) (cherry picked from commit 7e17679)
*Casts a proper Summon Pet spell on a hunter logging in for the first time (depending on his race). *Relocates created tamed pets before they're added to map. (cherry picked from commit 090951b)
(cherry picked from commit ab601de)
…pace) when attempting to extract M2 models from MPQ (cherry picked from commit 50e7b93)
…mo extensions (cherry picked from commit 4a3f229)
closes #31296 by CraftedRO
closes #31298 by CraftedRO
closes #31308 by Jildor
closes #31304 by CraftedRO
closes #31312 by CraftedRO
closes #31310 by CraftedRO
…trance in normal mode Closes #31581
Credit for some things goes to CMaNGOS Closes #21654
Partially based on CMaNGOS' script
…vement without delaying anything to next update tick (for use with instant "movement" like facing changes)
…en MovementGeneratorComparator and MotionMaster::DirectAdd * Also changed generators container from multiset to set because uniqueness was already ensured by deactivation logic in MotionMaster::DirectAdd
(cherry picked from commit 20b29c5)
(cherry picked from commit 39fc9f8)
closes #31650 by danaton
…fter teleporting to a different map while feared or confused
…layer::SendInitialPacketsAfterAddToMap, already handled by SMSG_MULTIPLE_MOVES
…in the same map while not being in control of their character
… while handling speed change ack packet Closes #29475
Credit for some ideas, pieces of code goes to CMaNGOS
…ing other movement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Target branch(es): 335/6x
Issues addressed: Fixes #
Tests performed: (Does it build, tested in-game, etc)
Known issues and TODO list: