refactor(core): simplify StyleSpecBuilder build method - #825
Merged
Conversation
- Move didUpdateWidget after _handleControllerChange for better code organization - Remove redundant wrapping logic from StyleSpecBuilder.build() - Delegate StyleSpecProvider and RenderModifiers wrapping to StyleAnimationBuilder
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This reverts commit cb6ec49.
github-actions
Bot
added
documentation
github-actions
Bot
removed
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#790
Description
This PR simplifies the
StyleSpecBuilderwidget by reorganizing code for better readability and removing redundant wrapping logic from the build method.Changes
didUpdateWidgetmethod after_handleControllerChangefor better logical flowStyleSpecBuilder.build()Review Checklist
Additional Information (optional)
This is a refactor with no functional changes