chore: add "engines" to package.json (PT-185071892)#786
Open
chore: add "engines" to package.json (PT-185071892)#786
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 81.56% 81.54% -0.02%
==========================================
Files 218 220 +2
Lines 8750 8758 +8
Branches 2389 2369 -20
==========================================
+ Hits 7137 7142 +5
+ Misses 1537 1535 -2
- Partials 76 81 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kswenson
requested changes
May 5, 2023
Member
kswenson
left a comment
There was a problem hiding this comment.
The engineStrict field is no longer used, so its presence here would only be confusing: https://docs.npmjs.com/cli/v6/configuring-npm/package-json#enginestrict.
433eros
added a commit
to concord-consortium/cloud-file-manager
that referenced
this pull request
May 5, 2023
"engineStrict" in 'package.json' is deprecated, see concord-consortium/codap#786 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.