Skip to content

Add llvm-openmp as recommended OpenMP runtime for Windows#2804

Merged
isuruf merged 2 commits into
conda-forge:mainfrom
matthewfeickert:mnt/add-vcomp14
Jun 10, 2026
Merged

Add llvm-openmp as recommended OpenMP runtime for Windows#2804
isuruf merged 2 commits into
conda-forge:mainfrom
matthewfeickert:mnt/add-vcomp14

Conversation

@matthewfeickert

@matthewfeickert matthewfeickert commented Apr 10, 2026

Copy link
Copy Markdown
Member

PR Checklist:

  • [N/A] note any issues closed by this PR with closing keywords
  • [N/A] if you are adding a new page under docs/ or community/, you have added it to the sidebar in the corresponding _sidebar.json file
  • [N/A] put any other relevant information below

@matthewfeickert matthewfeickert requested a review from a team as a code owner April 10, 2026 05:17
@netlify

netlify Bot commented Apr 10, 2026

Copy link
Copy Markdown

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit f7c49c8
🔍 Latest deploy log https://app.netlify.com/projects/conda-forge-previews/deploys/6a287d42ff117b0008a945c6
😎 Deploy Preview https://deploy-preview-2804--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71
Accessibility: 96
Best Practices: 100
SEO: 89
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@matthewfeickert matthewfeickert left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewfeickert

Copy link
Copy Markdown
Member Author

👋 Ping to @conda-forge/core for review.

@isuruf

isuruf commented Apr 14, 2026

Copy link
Copy Markdown
Member

I wouldn't recommend vcomp14 as it's not updated anymore by microsoft and they are switching to llvm openmp soon.

@matthewfeickert

Copy link
Copy Markdown
Member Author

I wouldn't recommend vcomp14 as it's not updated anymore by microsoft and they are switching to llvm openmp soon.

Oh that's good news (I think). For the immediate time period, there are llvm-openmp build for win-64, so should existing recipes that currently are using vcomp14 start switching to llvm-openmp?

@isuruf

isuruf commented Apr 14, 2026

Copy link
Copy Markdown
Member

Yes, but it needs a separate option. See https://learn.microsoft.com/en-us/cpp/build/reference/openmp-enable-openmp-2-0-support?view=msvc-170

@matthewfeickert

Copy link
Copy Markdown
Member Author

Yes, but it needs a separate option. See https://learn.microsoft.com/en-us/cpp/build/reference/openmp-enable-openmp-2-0-support?view=msvc-170

Okay, so seems like we need to use the /openmp:llvm option for Windows. So need to make it clear that people either need to set that in their code or set it through something like

build:
   script:
    - if: win
      then: set "CXXFLAGS=%CXXFLAGS% /openmp:llvm"
...

@matthewfeickert matthewfeickert changed the title Add vcomp14 as recommended OpenMP runtime for Windows Add llvm-openmp as recommended OpenMP runtime for Windows Apr 16, 2026
@matthewfeickert matthewfeickert force-pushed the mnt/add-vcomp14 branch 2 times, most recently from 5ce9ef5 to b739f4d Compare April 16, 2026 07:43
@matthewfeickert

matthewfeickert commented Apr 16, 2026

Copy link
Copy Markdown
Member Author

@conda-forge/core I think this is ready for review again.

The linter error I don't think is associated with my PR:

### Errors in build/docs/maintainer/infrastructure/index.html

* [404] [https://github.com/conda-forge/staged-recipes/blob/main/.github/workflows/automate-review-labels.yml](https://github.com/conda-forge/staged-recipes/blob/main/.github/workflows/automate-review-labels.yml) | Failed: Network error: Not Found

@matthewfeickert

Copy link
Copy Markdown
Member Author

👋 ping to @conda-forge/core for review.

@matthewfeickert

Copy link
Copy Markdown
Member Author

👋 ping to @conda-forge/core.

@matthewfeickert matthewfeickert force-pushed the mnt/add-vcomp14 branch 2 times, most recently from 198f7f1 to 6f7987a Compare May 14, 2026 03:08
@chrisburr

Copy link
Copy Markdown
Member

I think this looks like it's ready to merged. @h-vetinari/@isuruf as you know better than I do for Windows, do you agree?

* Add recommendation of having llvm-openmp be a host requirement for Windows
  builds that need an OpenMP runtime and note that for this to work the
  /openmp:llvm option must be added.
   - c.f. https://learn.microsoft.com/en-us/cpp/build/reference/openmp-enable-openmp-2-0-support?view=msvc-170
@isuruf isuruf enabled auto-merge June 9, 2026 20:54
@matthewfeickert

Copy link
Copy Markdown
Member Author

Thanks for the review @isuruf. Though the "checks links" linter that is failing given the state of the HEAD of main is keeping all checks from completing and so auto-merge won't pass. Can you please manually merge this?

@matthewfeickert

Copy link
Copy Markdown
Member Author

cc @conda-forge/core RE: manual merge request in #2804 (comment).

@isuruf isuruf disabled auto-merge June 10, 2026 01:49
@isuruf isuruf merged commit 8996890 into conda-forge:main Jun 10, 2026
8 of 9 checks passed
@matthewfeickert matthewfeickert deleted the mnt/add-vcomp14 branch June 10, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants