Add llvm-openmp as recommended OpenMP runtime for Windows#2804
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewfeickert
left a comment
There was a problem hiding this comment.
Relevant build preview page: https://deploy-preview-2804--conda-forge-previews.netlify.app/docs/maintainer/knowledge_base/#openmp
|
👋 Ping to @conda-forge/core for review. |
0c6faa7 to
7397722
Compare
|
I wouldn't recommend vcomp14 as it's not updated anymore by microsoft and they are switching to llvm openmp soon. |
Oh that's good news (I think). For the immediate time period, there are |
|
Yes, but it needs a separate option. See https://learn.microsoft.com/en-us/cpp/build/reference/openmp-enable-openmp-2-0-support?view=msvc-170 |
Okay, so seems like we need to use the build:
script:
- if: win
then: set "CXXFLAGS=%CXXFLAGS% /openmp:llvm"
... |
7397722 to
ce41be2
Compare
5ce9ef5 to
b739f4d
Compare
|
@conda-forge/core I think this is ready for review again. The linter error I don't think is associated with my PR: |
daa6861 to
116185f
Compare
|
👋 ping to @conda-forge/core for review. |
116185f to
a2d957f
Compare
|
👋 ping to @conda-forge/core. |
198f7f1 to
6f7987a
Compare
|
I think this looks like it's ready to merged. @h-vetinari/@isuruf as you know better than I do for Windows, do you agree? |
* Add recommendation of having llvm-openmp be a host requirement for Windows builds that need an OpenMP runtime and note that for this to work the /openmp:llvm option must be added. - c.f. https://learn.microsoft.com/en-us/cpp/build/reference/openmp-enable-openmp-2-0-support?view=msvc-170
6f7987a to
79eef71
Compare
|
Thanks for the review @isuruf. Though the "checks links" linter that is failing given the state of the HEAD of |
|
cc @conda-forge/core RE: manual merge request in #2804 (comment). |

llvm-openmpbe a host requirement for Windows builds that need an OpenMP runtime and note that for this to work the/openmp:llvmoption must be added.PR Checklist:
docs/orcommunity/, you have added it to the sidebar in the corresponding_sidebar.jsonfile