Skip to content

Replace the existing stale container when adding work container #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cserspring wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −2
Open

Replace the existing stale container when adding work container #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...llel-consumer-core/src/main/java/io/confluent/parallelconsumer/state/ProcessingShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,17 @@ public class ProcessingShard<K, V> {

public void addWorkContainer(WorkContainer<K, V> wc) {
long key = wc.offset();
if (entries.containsKey(key)) {
log.debug("Entry for {} already exists in shard queue, dropping record", wc);
WorkContainer<K, V> existing = entries.get(key);
if (existing != null) {
// Check if the existing entry is stale and should be replaced
if (isWorkContainerStale(existing)) {
log.debug("Replacing stale entry (epoch {}) for offset {} with fresh one (epoch {})",
existing.getEpoch(), key, wc.getEpoch());
entries.put(key, wc);
// availableWorkContainerCnt stays the same since we're replacing, not adding
} else {
log.debug("Entry for {} already exists in shard queue, dropping record", wc);
}
} else {
entries.put(key, wc);
availableWorkContainerCnt.incrementAndGet();
Expand Down