fix cve-2026-42499: Upgrade Go to 1.26.3#3356
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoFix CVE-2026-42499 by upgrading Go toolchain to 1.26.3 Description
Diagram
High-Level Assessment
Files changed (3)
|
|
🤖 Finished Review · ✅ Success · Started 11:40 AM UTC · Completed 11:48 AM UTC |
Code Review by Qodo
Context used✅ Compliance rules (platform):
27 rules 1. Asdf Go version mismatch
|
ReviewFindingsHigh
Labels: PR bumps Go toolchain version across Dockerfiles, go.mod files, and build tooling to fix CVEs Previous runLooks good to me Previous run (2)ReviewFindingsMedium
Low
Info
Previous run (3)ReviewFindingsMedium
Low
Info
|
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 11:53 AM UTC · Completed 11:59 AM UTC |
| ## Build | ||
|
|
||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.25.9@sha256:90a36bc2013b3fcb28e2a4b082c9b895d7c2c679e58b95aed9721970f3339d0e AS build | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1781757851@sha256:1503a8227c00a1934e3c1a4a88e0be785786a2d9e2f62a9334e75ff2fadca2fe AS build |
There was a problem hiding this comment.
This version change seems unusual. Is it really going from 1.15.9 to 9.8?
There was a problem hiding this comment.
seems the naming convention was somehow changed, maybe ?
I took the image from https://catalog.redhat.com/en/software/containers/ubi9/go-toolset/61e5c00b4ec9945c18787690#overview
go version go1.26.3 (Red Hat 1.26.3-1.el9_8) linux/amd64
There was a problem hiding this comment.
I will update with the correct tag:
registry.access.redhat.com/ubi9/go-toolset:1.26.3-1781757851@sha256:1503a8227c00a1934e3c1a4a88e0be785786a2d9e2f62a9334e75ff2fadca2fe
There was a problem hiding this comment.
I think Renovate works better with the short tag, i.e.:
| FROM registry.access.redhat.com/ubi9/go-toolset:9.8-1781757851@sha256:1503a8227c00a1934e3c1a4a88e0be785786a2d9e2f62a9334e75ff2fadca2fe AS build | |
| FROM registry.access.redhat.com/ubi9/go-toolset:1.26.3@sha256:1503a8227c00a1934e3c1a4a88e0be785786a2d9e2f62a9334e75ff2fadca2fe AS build |
In theory, renovate could generate a PR to update the digest if a newer 1.26.3 appears.
There was a problem hiding this comment.
Is there a particular reason to not use the latest 1.26.3? I'd probably use this digest:
$ skopeo inspect --raw docker://registry.access.redhat.com/ubi9/go-toolset:1.26.3 | sha256sum
17c888d75753f128f6cbdc5587932c3abd2632ca8e0931aa27b9a60c7a75ac62 -
There was a problem hiding this comment.
you're right! done. Thank you!
one more thing, I am not sure I can debug the EC build issue, I don't have permissions to have a look.
|
/ok-to-test |
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 1:10 PM UTC · Completed 1:16 PM UTC |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 10:22 PM UTC · Completed 10:28 PM UTC |
| ## Build | ||
|
|
||
| FROM docker.io/library/golang:1.25.9 AS build | ||
| FROM docker.io/library/golang:1.26.3 AS build |
There was a problem hiding this comment.
[high] protected-path
This PR modifies Dockerfile, which is a protected infrastructure file requiring human approval. The PR has no linked issue to authorize the change. While the PR description references CVE-2026-42499, CVE-2026-39820, and CVE-2026-33811 as motivation, protected-path changes require a linked issue for traceability.
Suggested fix: Link an issue authorizing this Dockerfile change, or obtain explicit human maintainer approval.
Fixes: