fix: remove persist-credentials to allow repo-sync push#6
Open
robnester-rh wants to merge 1 commit into
Open
Conversation
The persist-credentials: false setting prevents git push from authenticating since checkout doesn't store the token in .git/config. The app token is already scoped and short-lived, so persisting it for the duration of the job is safe and necessary for the push step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe repo-sync workflow checkout step now fetches full git history and no longer disables credential persistence. ChangesRepo sync checkout settings
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
st3penta
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
persist-credentials: falseadded in PR #5 preventsgit pushfrom authenticating — the checkout action doesn't store the token in.git/config, so the push step fails withcould not read Username.The app token is already scoped and short-lived, so persisting it for the job duration is safe and necessary.
Discovered via manual
workflow_dispatchrun: https://github.com/conforma/go-containerregistry/actions/runs/28171774706Test plan
workflow_dispatchon repo-sync after merging — push step should succeed🤖 Generated with Claude Code