Skip to content

fix: treat .local domains as local (use HTTP instead of HTTPS)#7

Merged
simonbaird merged 1 commit into
mainfrom
allow-plain-http-for-dot-local
Jun 26, 2026
Merged

fix: treat .local domains as local (use HTTP instead of HTTPS)#7
simonbaird merged 1 commit into
mainfrom
allow-plain-http-for-dot-local

Conversation

@simonbaird

Copy link
Copy Markdown
Member

Extend the reLocal regex to match *.local in addition to *.localhost, so that .local registries default to HTTP.

The Conforma CLI acceptance tests use a local registry that does not support TLS. Without this change, go-containerregistry attempts HTTPS connections to *.local registries, causing those tests to fail. We may add TLS to the acceptance-test cluster in the future, but for now let's do this to get the tests passing again.

See also commit 2d86301 where the regex was changed 8 weeks ago.

See also https://redhat.atlassian.net/browse/EC-1866

Extend the reLocal regex to match *.local in addition to *.localhost,
so that .local registries default to HTTP.

The Conforma CLI acceptance tests use a local registry that does not
support TLS. Without this change, go-containerregistry attempts HTTPS
connections to *.local registries, causing those tests to fail. We may
add TLS to the acceptance-test cluster in the future, but for now let's
do this to get the tests passing again.

See also commit 2d86301 where the regex was changed 8 weeks ago.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 3d556171-b8c0-46c3-b214-ec93f3b7ccab

📥 Commits

Reviewing files that changed from the base of the PR and between b752479 and 9855761.

📒 Files selected for processing (2)
  • pkg/name/registry.go
  • pkg/name/registry_test.go

📝 Walkthrough

Walkthrough

Registry.Scheme() now treats .local hosts like localhost-like registries and returns http for matching cases. The corresponding scheme test expectations were updated.

Changes

Local registry scheme change

Layer / File(s) Summary
Regex and scheme cases
pkg/name/registry.go, pkg/name/registry_test.go
reLocal now matches .local hosts, and TestRegistryScheme expects http for the updated matching domains.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: treating .local domains as local and using HTTP instead of HTTPS.
Description check ✅ Passed The description directly matches the change and explains the motivation and expected effect on .local registries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch allow-plain-http-for-dot-local

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
pkg/name/registry.go 72.46% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonbaird simonbaird merged commit ae5f0ae into main Jun 26, 2026
22 of 25 checks passed
simonbaird added a commit to simonbaird/conforma-cli that referenced this pull request Jun 26, 2026
My hope is that this gets our acceptance tests, particularly the
task_validate_image feature, passing again.

See conforma/go-containerregistry#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants