fix: treat .local domains as local (use HTTP instead of HTTPS)#7
Merged
Conversation
Extend the reLocal regex to match *.local in addition to *.localhost, so that .local registries default to HTTP. The Conforma CLI acceptance tests use a local registry that does not support TLS. Without this change, go-containerregistry attempts HTTPS connections to *.local registries, causing those tests to fail. We may add TLS to the acceptance-test cluster in the future, but for now let's do this to get the tests passing again. See also commit 2d86301 where the regex was changed 8 weeks ago. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesLocal registry scheme change
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
robnester-rh
approved these changes
Jun 26, 2026
simonbaird
added a commit
to simonbaird/conforma-cli
that referenced
this pull request
Jun 26, 2026
My hope is that this gets our acceptance tests, particularly the task_validate_image feature, passing again. See conforma/go-containerregistry#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the reLocal regex to match *.local in addition to *.localhost, so that .local registries default to HTTP.
The Conforma CLI acceptance tests use a local registry that does not support TLS. Without this change, go-containerregistry attempts HTTPS connections to *.local registries, causing those tests to fail. We may add TLS to the acceptance-test cluster in the future, but for now let's do this to get the tests passing again.
See also commit 2d86301 where the regex was changed 8 weeks ago.
See also https://redhat.atlassian.net/browse/EC-1866