-
Notifications
You must be signed in to change notification settings - Fork 52
Update go modules (release-v0.7) (minor) #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v0.7
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,12 @@ module github.com/conforma/policy | |
| go 1.24.2 | ||
|
|
||
| require ( | ||
| github.com/conforma/cli v0.7.109 | ||
| github.com/google/addlicense v1.1.1 | ||
| github.com/open-policy-agent/conftest v0.55.0 | ||
| github.com/styrainc/regal v0.29.2 | ||
| github.com/tektoncd/cli v0.39.1 | ||
| oras.land/oras v1.2.3 | ||
| github.com/conforma/cli v0.9.50 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] missing-artifacts The PR updates six dependencies in go.mod but does not include the corresponding go.sum update. Verification confirms that five of six new dependency versions (conforma/cli v0.9.50, conftest v0.68.2, regal v0.41.1, tektoncd/cli v0.45.0, oras v1.3.2) have no checksum entries in go.sum. Only addlicense v1.2.0 is already present. Without the updated go.sum, go build, go test, and go mod verify will fail. The pre-merge CI only triggers on PRs to main, not release-v0.7, so this gap may not be caught by automated checks. Suggested fix: Run go mod tidy in the root module directory and include the resulting go.sum changes in the PR. |
||
| github.com/google/addlicense v1.2.0 | ||
| github.com/open-policy-agent/conftest v0.68.2 | ||
| github.com/styrainc/regal v0.41.1 | ||
| github.com/tektoncd/cli v0.45.0 | ||
| oras.land/oras v1.3.2 | ||
| ) | ||
|
|
||
| require ( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] missing-artifacts
The PR updates conforma/cli v0.7.95 to v0.9.50 and godog v0.13.0 to v0.15.1, but does not include acceptance/go.sum changes. Verification confirms godog v0.15.1 already has entries, but conforma/cli v0.9.50 does not. The missing checksum will cause build failures in the acceptance module.
Suggested fix: Run go mod tidy in the acceptance/ directory and include the resulting acceptance/go.sum changes in the PR.