Skip to content

[feat][client][pip-230] Throw exception when MessageIdImpl and BatchMessag…#13

Open
congbobo184 wants to merge 7 commits intomasterfrom
congbo/pip-230
Open

[feat][client][pip-230] Throw exception when MessageIdImpl and BatchMessag…#13
congbobo184 wants to merge 7 commits intomasterfrom
congbo/pip-230

Conversation

@congbobo184
Copy link
Copy Markdown
Owner

…eIdImpl compare with each other

Fixes #xyz

Master Issue: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@congbobo184 congbobo184 changed the title [improve][pip-230] Throw exception when MessageIdImpl and BatchMessag… [PIP-230][improve] Throw exception when MessageIdImpl and BatchMessag… Dec 19, 2022
@congbobo184 congbobo184 changed the title [PIP-230][improve] Throw exception when MessageIdImpl and BatchMessag… [feat][PIP-230] Throw exception when MessageIdImpl and BatchMessag… Dec 19, 2022
@congbobo184 congbobo184 changed the title [feat][PIP-230] Throw exception when MessageIdImpl and BatchMessag… [feat][client][pip-230] Throw exception when MessageIdImpl and BatchMessag… Dec 19, 2022
@github-actions
Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant