Conversation
drolsen
approved these changes
May 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new array of options to
fc-config.jscalledcodeStyle.This array will be used to house code style options that are used in the build/scaffolding processes, starting with
pascalClassNames.pascalClassNamesdefaults tofalse, but when this is switched totruethe FC scaffolding tasks will use PascalCase for the CSS class names on newly-generated atoms/molecules/organisms/modifiers.This option will not change the baseline components and only affects new ones. The reason for this is to keep things simple and maintainable, while improving backwards-compatibility with components that may have been generated with PascalCase class names with older versions of FC.
See #365 for more information and context.
Types of changes