Switch to a path identifier for yml files to define variants.#6
Open
mattloose wants to merge 2 commits intoconnor-lab:mainfrom
Open
Switch to a path identifier for yml files to define variants.#6mattloose wants to merge 2 commits intoconnor-lab:mainfrom
mattloose wants to merge 2 commits intoconnor-lab:mainfrom
Conversation
Switch to use a single folder rather than a list of files for the yml definitions.
Remove list requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous pull request didn't actually work...
This changes the behaviour of the typing_yaml argument to make it read the contents of a folder and find all .yml files within it. This may not be the desired behaviour but matches the original written description of the argument.
However, it does prevent users from explicitly checking against just one variant definition yml.