feat: add installation target to Makefile for ipc-cli and fendermint #1497
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoAtwill
approved these changes
Jan 27, 2026
…ssue The nested ds-test submodule in ExcessivelySafeCall was pointing to commit 9310e879db8ba3ea6d5c6489a579118fd264a3f5 which no longer exists in the public dapphub/ds-test repository. This caused CI failures when trying to fetch submodules recursively. Updated ExcessivelySafeCall from commit 81cd99c (main branch) to 3de8bf3 (prestwich/updates branch) which: - Replaces ds-test with forge-std (modern Foundry testing framework) - Uses ds-test commit e282159 (current master) which is publicly available - Maintains backward compatibility - no changes to ExcessivelySafeCall API - Only updates test infrastructure, not implementation code This resolves the "fatal: could not read Username" error in CI when initializing submodules. Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds a simple installation workflow.
installMakefile target (depends ondefault) copies./target/release/ipc-cliand./target/release/fendermintto~/.cargo/bin, ensures executability, and prints PATH/confirmation messages.Written by Cursor Bugbot for commit 7bac9dd. This will update automatically on new commits. Configure here.
Closes #1467