feat(Navbar): controlled subMenu#67
Merged
gizeasy merged 32 commits intoNov 10, 2025
Merged
Conversation
- Added `NavbarPropGetItemSubMenuOpen` - Added `NavbarPropOnItemSubMenuToggle` - Updated `NavbarProps` and `NavbarItemProps` to support controlled sub-menu behavior
- Pass `getItemSubMenuOpen` and `onItemSubMenuToggle` to `NavbarItem` - Update `withDefaultGetters`
- Add controlled/uncontrolled logic via `getItemSubMenuOpen` and `onItemSubMenuToggle` - Use external state when controlled, preserve local state otherwise - Update click handlers and arrow toggle behavior - Ensure backward compatibility
ShavrinAleksei
requested review from
N1MBER,
arhayka and
gizeasy
as code owners
Contributor
Author
|
Описание изменений Ключевые изменения
Закрыт issue: Navbar: управление состоянием подменю #4063 |
gizeasy
requested changes
Nov 5, 2025
- Replaced onItemSubMenuToggle with onSubMenuToggle in handleToggle - Added useEffect for syncing controlled open state - Removed isControlled flag for simpler logic
gizeasy
requested changes
Nov 6, 2025
gizeasy
requested changes
Nov 6, 2025
|
|
||
| Для управления состоянием подменю (открыто/закрыто) используйте связку getItemSubMenuOpen и onSubMenuToggle. Это позволяет контролировать открытие подменю через внешний стейт, включая задание начального состояния. | ||
|
|
||
| ```tsx |
Collaborator
There was a problem hiding this comment.
давай живой пример создадим который пощелкать можно будет.
менюха с 3мя пунктами
- Пункт 1
- Пункт 2
- Пункт 3
и 3 кнопки
- Открыть 1
- Открыть 2
- Открыть 3
если пункт открыт то кнопку переименуй в закрыть
|
|
||
| export type NavbarPropGetItemSubMenuOpen<ITEM> = ( | ||
| item: ITEM, | ||
| ) => boolean | undefined; |
Collaborator
There was a problem hiding this comment.
undefined думаю стоит убрать так как далее по логике у нас
const controlledOpen = getItemSubMenuOpen?.(item);
useEffect(() => {
if (controlledOpen !== undefined) {
setOpen.set(controlledOpen);
}
}, [controlledOpen]);
где если приходит undefined то мы считаем что контролировать пункт не надо и не будем синкать внутреннее состояние. А пользователь может подумать что если не true то будет закрываться, и отдаст undefined. Пусть будет строго boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание изменений
Чек-лист
Опционально