Add the option to see if a Power on Reset has taken place and the RTC data is NOT valid.#12
Open
bricomp wants to merge 10 commits intoconstiko:masterfrom
Open
Add the option to see if a Power on Reset has taken place and the RTC data is NOT valid.#12bricomp wants to merge 10 commits intoconstiko:masterfrom
bricomp wants to merge 10 commits intoconstiko:masterfrom
Conversation
constiko
requested changes
Feb 9, 2024
Owner
constiko
left a comment
There was a problem hiding this comment.
Thanks Robert! Could you remove the two extra source files?
Author
|
Which two files?
From: Constantin Koch ***@***.***>
Sent: 09 February 2024 16:29
To: constiko/RV-3028_C7-Arduino_Library ***@***.***>
Cc: bricomp ***@***.***>; Author ***@***.***>
Subject: Re: [constiko/RV-3028_C7-Arduino_Library] Add the option to see if a Power on Reset has taken place and the RTC data is NOT valid. (PR #12)
@constiko requested changes on this pull request.
Thanks Robert! Could you remove the two extra source files?
—
Reply to this email directly, view it on GitHub <#12 (review)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOXC77PR6IBLKOLSG6FMDYSZFE3AVCNFSM6AAAAABDBTFOPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZSG44DAOBXGQ> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/AAXOXC6B4DJAIEWBDP3Z3EDYSZFE3A5CNFSM6AAAAABDBTFOPCWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTPUBPEU.gif> Message ID: ***@***.*** ***@***.***> >
|
Author
|
I think I have got it now!Sent from Outlook for Android
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option to see if a Power on Reset has taken place and the RTC data is NOT valid.
Upon a program start it is useful to detect whether the RTC data is valid (or Not).
With the following changes this is possible.
timeUpdateRequired = readBit(RV3028_STATUS, STATUS_PORF);
In that way as soon as the RTC.begin is initiated the variable RTC.timeUpdateRequired can investigated to see if the date/time needs setting on the 3028.