feat(cgroup1): skip cgroup1 update operation if not configured in LinuxResources #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uxResources Signed-off-by: Derek Ray <derek9ray@gmail.com>
dcantah
approved these changes
Jan 13, 2026
fuweid
requested changes
Jan 15, 2026
| } | ||
|
|
||
| func (c *cpuController) Update(path string, resources *specs.LinuxResources) error { | ||
| if resources == nil || resources.CPU == nil || (resources.CPU.Shares == nil && resources.CPU.Period == nil && resources.CPU.Quota == nil) { |
Member
There was a problem hiding this comment.
*.Create already handles nil case.
If we check it before update/create operation, it's easy to cause mismatch.
For example, I just want to update shares only. this is breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check LinuxResources field, and skip Update() operation if not specified or invalid to avoid the potential panic issue of misconfigure