fix: logs updated on starting of a stopped container#3896
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom May 7, 2025
Merged
fix: logs updated on starting of a stopped container#3896AkihiroSuda merged 1 commit intocontainerd:mainfrom
AkihiroSuda merged 1 commit intocontainerd:mainfrom
Conversation
49019a2 to
ccb179d
Compare
Contributor
Author
|
@AkihiroSuda |
fahedouch
reviewed
Feb 20, 2025
ccb179d to
e8fb6c4
Compare
Contributor
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
apostasie
reviewed
Feb 22, 2025
Contributor
|
@Shubhranshu153 I just have a batch of nits on the test. Btw, feedback on the test framework is highly welcome. Ideally, if we get #3591 in first, we can get rid of the added DelayOnceReaders here (and unbuffer). But anyhow, don't sweat it - I can clean that up afterwards if needed. |
apostasie
approved these changes
Feb 22, 2025
df70bc7 to
72193e6
Compare
apostasie
reviewed
Feb 24, 2025
apostasie
reviewed
Feb 24, 2025
Member
|
Needs rebase |
apostasie
reviewed
May 1, 2025
2c39201 to
65616d7
Compare
apostasie
reviewed
May 1, 2025
apostasie
reviewed
May 1, 2025
apostasie
approved these changes
May 1, 2025
9b25406 to
8a8f662
Compare
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
8a8f662 to
2c91198
Compare
Contributor
Author
this seems like an error regarding go mod jail? Not sure why go.mod is read during runtime. |
Contributor
It is (AkihiroSuda/gomodjail#50). Gomodjail errors can be ignored for now. |
Contributor
Author
Contributor
Author
|
Rerunning the test for flaky test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When we start a container that was running and stopped or exited, logs are not updated.
Steps to Reproduce:
step 1: Run and exit container
fix:
The pr fixes it by adding multiwriters to start of containers.
Interactive Flag Added to start
Nerdctl didn't support interactive flag so added the flag to have compatible behavior with docker