Run project-checks@v1.1.0 in CI#14
Closed
austinvazquez wants to merge 1 commit intocontainerd:mainfrom
Closed
Conversation
This was referenced Feb 20, 2025
AkihiroSuda
reviewed
Mar 4, 2025
.github/workflows/ci.yml
Outdated
| go-version: "1.22" | ||
| cache: false | ||
|
|
||
| - uses: containerd/project-checks@v1.1.0 |
Member
There was a problem hiding this comment.
Suggested change
| - uses: containerd/project-checks@v1.1.0 | |
| - uses: ./ |
Member
Why not? |
Member
Author
|
Yeah we need CI for project checks. Let me try the syntax you suggested and see if that works well. |
austinvazquez
force-pushed
the
run-project-checks-in-ci
branch
3 times, most recently
from
e86b2fc to
506cf68
Compare
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
run-project-checks-in-ci
branch
from
506cf68 to
e4f5213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The project checks package helps maintainers spot check pull requests for common checks across the containerd organization. We want to run these same checks on the project-checks package to validate contributions to it as well.
Description
This change is to run project-checks@v1.1.0 in CI.
Note: this is not testing the changes made to project-checks in CI.