Pass the containerd address into shim#192
Merged
Mossaka merged 1 commit intocontainerd:mainfrom Jul 26, 2023
Merged
Conversation
Contributor
Author
|
seems like CI might be broken after #187 |
Collaborator
|
@jsturtevant #193 has been fixed. It should work now after rebasing your changes. |
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
use-shim-args
branch
2 times, most recently
from
210d78f to
7bfcc55
Compare
cpuguy83
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Rust-extensions dep to include containerd/rust-extensions#150 which enables using containerd from within the shim. This is in perp for handling oci artifacts that will be stored in the containerd content store in which we need the containerd address.