Merged
Conversation
1f1c9e2 to
70231f3
Compare
Collaborator
Author
|
@CaptainVincent , this is an alternative fix to #280. |
Mossaka
reviewed
Aug 29, 2023
Collaborator
Author
|
Rebased to account for #290. |
Collaborator
Author
|
@Mossaka @jsturtevant PTAL. |
jsturtevant
reviewed
Aug 31, 2023
Contributor
jsturtevant
left a comment
There was a problem hiding this comment.
LGTM, few comments to help my understanding
Mossaka
previously approved these changes
Aug 31, 2023
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Mossaka
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #260 the stdio
fdare dangling in the parent shim process.Normally redirecting the
stdiowould clear thefds.However, the redirection happens in the
clone3d child process.This means that the parent process maintains a dangling cope of the ´fd´s, keps alive by the shim
Instances.The key changes in this PR are:
Stdionow offers atakemethod.Instanceimpls now usestdio.take()for the last executor, giving up ownership of thefds.The rest of the changes are general fixes:
MuxtexinStdioto anAtomicCell(we need two nested ones to be able to implement ´take´)Stdiowith a generic const.TryFrom<&InstanceConfig<Engine>>forStdio