seccomp: allow perf_event_open if CAP_PERFMON#2534
Closed
blue42u wants to merge 1 commit intocontainers:mainfrom
blue42u:cap-perfmon
Closed
seccomp: allow perf_event_open if CAP_PERFMON#2534blue42u wants to merge 1 commit intocontainers:mainfrom blue42u:cap-perfmon
blue42u wants to merge 1 commit intocontainers:mainfrom
blue42u:cap-perfmon
Conversation
Previously perf_event_open was only allowed if both CAP_SYS_ADMIN and CAP_PERFMON were granted. CAP_SYS_ADMIN in particular is a very overloaded capability and is best avoided. This commit enables perf_event_open if either (or both) capabilities are set, in particular this enables containers with only CAP_PERFMON to profile itself. This change does not deny anything new, nor does it enable perf_event_open by default. Signed-off-by: Jonathon Anderson <anderson.jonathonm@gmail.com>
|
This repository has been migrated to https://github.com/containers/container-libs. Please open your PR there. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blue42u The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
perf_event_openis only allowed if bothCAP_SYS_ADMINandCAP_PERFMONare enabled.CAP_SYS_ADMINis a very overloaded capability and is best avoided. This PR enablesperf_event_openif either (or both) capabilities are enabled. In particular, this enables a container to profile itself by only enablingCAP_PERFMON.This change does not deny anything new, nor does it enable
perf_event_openby default. In summary:perf_event_openreturn (before)perf_event_openreturn (after)CAP_PERFMON+CAP_SYS_ADMINCAP_PERFMONEPERMCAP_SYS_ADMINENOSYSEPERMEPERM