secrets: enhance logging for shell driver and store operations#2537
Closed
ZuhairM7 wants to merge 1 commit intocontainers:mainfrom
Closed
secrets: enhance logging for shell driver and store operations#2537ZuhairM7 wants to merge 1 commit intocontainers:mainfrom
ZuhairM7 wants to merge 1 commit intocontainers:mainfrom
Conversation
This patch adds DEBUG logging to the shell driver to print the exact command and environment variables being executed. It also adds TRACE logging to the SecretsManager.Store method and improves error wrapping to distinguish between driver errors and metadata storage errors. Fixes containers/podman#27635 Signed-off-by: ZuhairM7 <zuhairmerali@gmail.com>
|
This repository has been migrated to https://github.com/containers/container-libs. Please open your PR there. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ZuhairM7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds DEBUG logging to the shell driver to print the exact command and environment variables being executed. It also adds TRACE logging to the SecretsManager.Store method and improves error wrapping to distinguish between driver errors and metadata storage errors.
Fixes containers/podman#27635