Add more Netavark create tests#1431
Merged
Luap99 merged 4 commits intocontainers:mainfrom Apr 15, 2026
Merged
Conversation
Luap99
reviewed
Apr 10, 2026
Adapted from container-libs/common/libnetwork/netavark/config_test.go using agentic AI, for more test coverage. Signed-off-by: Ashley Cui <acui@redhat.com>
Automatically set ipv6_enabled=true when any subnet in the network is IPv6. This matches the behavior of the Go implementation in container-libs. Signed-off-by: Ashley Cui <acui@redhat.com>
ashley-cui
force-pushed
the
create
branch
2 times, most recently
from
f474751 to
99d91f1
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Validate that subnets within the same network do not overlap or duplicate each other. This matches the behavior of the Go implementation. Signed-off-by: Ashley Cui <acui@redhat.com>
These fields cannot be changed. Signed-off-by: Ashley Cui <acui@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked Claude to adapt missing tests from container-libs/common/libnetwork/netavark/create.go for more test coverage. In the process, it found two differences in validation, so now we validate subnet overlap and auto-detect ipv6 networks.