Use proxy from container libs#2816
Merged
mtrmac merged 2 commits intocontainers:mainfrom Mar 19, 2026
Merged
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
2 times, most recently
from
0a0288f to
c31b9a2
Compare
cgwalters
suggested changes
Mar 3, 2026
Collaborator
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Thanks for working on this!!
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
from
c31b9a2 to
f7722ac
Compare
giuseppe
changed the title
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
2 times, most recently
from
d97421a to
eba4f23
Compare
Member
|
That's some serious code consolidation. The change LGTM in general. |
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
2 times, most recently
from
62155ea to
150d4af
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
from
150d4af to
7f09762
Compare
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
from
7f09762 to
3d580eb
Compare
mtrmac
reviewed
Mar 19, 2026
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
use-proxy-from-container-libs
branch
from
3d580eb to
2eb170a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skopeo changes for containers/container-libs#677