HMS-9590: update repos and scripts upon frontend refactor#1358
Open
Starle21 wants to merge 1 commit intocontent-services:mainfrom
Open
HMS-9590: update repos and scripts upon frontend refactor#1358Starle21 wants to merge 1 commit intocontent-services:mainfrom
Starle21 wants to merge 1 commit intocontent-services:mainfrom
Conversation
Contributor
Member
There was a problem hiding this comment.
1 comment for the new command, I think we should update the old one instead 💭
and this PR is also missing an update to the GH workflow for CI where the command is used (we also run frontend tests there, so those would break after the FE changes) 👀
one other thing is, if the small codeready repo would be removed from the setup, some of our backend PW tests would break
(also in the helpers inside test-utils, we have a constant with the URL for the small testing repo, that might also need to be changed, if the repo isn't going to be available) 😅
Due to the frontend refactor in frontend PR content-services#763, there was a need to import also hardcoded repositories in the script that is used for local playwright tests. The script repos-minimal imports the previous EPEL and SMALL repo, plus 2 hardcoded repos. A new script which counts the duration how long it takes to import and snapshot or introspect the required repos for testing has been added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the frontend refactor in frontend PR #763,
there was a need to update playwright tests
and the accompanied repositories and the script
that are used for local playwright tests.
Now,
repos-minimalscript importshardcodedrepositoriesnext to the original
epel10andsmallrepositories.A new script which counts
the duration how long it takes to import
and snapshot or introspect the required repos
for testing has been added.