HMS-10265: templatize deployment.yaml#1406
Conversation
jlsherrill
force-pushed
the
10265
branch
3 times, most recently
from
b31e519 to
3ff67a5
Compare
| default: stage | ||
| - name: IMAGE | ||
| value: quay.io/redhat-services-prod/insights-management-tenant/insights-content-sources/content-sources-backend | ||
| - name: WEEKLY_CRON_JOB |
There was a problem hiding this comment.
Do we still need to keep this whole list of parameters at the bottom of the template updated? Can we ignore the ones defined in env-variables?
There was a problem hiding this comment.
we do, i could move it to the env file, which might make sense, so then they are all in a single place. I thought about it, but wasn't sold either way.
There was a problem hiding this comment.
so i mean to say, if you think it makes sense to put them there, i'll do that
There was a problem hiding this comment.
I think I like the idea of them being in a single place, so we don't have to remember to update them in two places. Were there drawbacks to that? I could be missing something. I guess it probably makes the parsing it a little trickier when generating the deployment.yaml
There was a problem hiding this comment.
nah, i think its fine, i'll update
3 participants
Summary
Templatizes the deployment.yaml using a single list of environment variables.
Testing steps
tests pass