Skip to content

No merge: Initial BMFF embeddable support experiment#1808

Closed
mauricefisher64 wants to merge 5 commits intomainfrom
emeddable_bmff
Closed

No merge: Initial BMFF embeddable support experiment#1808
mauricefisher64 wants to merge 5 commits intomainfrom
emeddable_bmff

Conversation

@mauricefisher64
Copy link
Copy Markdown
Collaborator

Changes in this pull request

Give a narrative description of what has been changed.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

…eddable_bmff

# Conflicts:
#	c2pa_c_ffi/src/c_api.rs
#	sdk/src/builder.rs
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 65.59140% with 192 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.58%. Comparing base (355d27a) to head (2d4b969).
⚠️ Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/assertions/bmff_hash.rs 49.06% 82 Missing ⚠️
c2pa_c_ffi/src/c_api.rs 67.94% 75 Missing ⚠️
sdk/src/store.rs 73.33% 20 Missing ⚠️
sdk/src/utils/hash_utils.rs 30.76% 9 Missing ⚠️
sdk/src/builder.rs 89.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   76.64%   76.58%   -0.06%     
==========================================
  Files         172      172              
  Lines       39927    40395     +468     
==========================================
+ Hits        30601    30937     +336     
- Misses       9326     9458     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 10, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing emeddable_bmff (2d4b969) with main (355d27a)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mauricefisher64
Copy link
Copy Markdown
Collaborator Author

Work merged as part of another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant