fix!: disable HTTP redirects in restricted networking implementation#1907
Merged
fix!: disable HTTP redirects in restricted networking implementation#1907
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
tmathern
approved these changes
Mar 6, 2026
Contributor
Author
|
TODO: Change behavior to only disable redirects if restricted networking is enabled after discussion with @gpeacock. |
Contributor
Author
|
Redirects for the timestamp case will be fixed in #1855. |
scouten-adobe
approved these changes
Apr 1, 2026
gpeacock
approved these changes
Apr 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables HTTP redirects in the built-in networking implementation. The built-in WASM/WASI implementation currently does not follow redirects so this change will align all platforms. To properly support redirects consistently means we have to implement our own functionality and also tie that into the restricted networking settings. I believe this is out of scope for the SDK.
A custom HTTP implementation can be user-supplied via a HTTP resolver in the Context.