Skip to content

fix!: disable HTTP redirects in restricted networking implementation#1907

Merged
ok-nick merged 10 commits intomainfrom
ok-nick/no-redirects
Apr 2, 2026
Merged

fix!: disable HTTP redirects in restricted networking implementation#1907
ok-nick merged 10 commits intomainfrom
ok-nick/no-redirects

Conversation

@ok-nick
Copy link
Copy Markdown
Contributor

@ok-nick ok-nick commented Mar 6, 2026

Disables HTTP redirects in the built-in networking implementation. The built-in WASM/WASI implementation currently does not follow redirects so this change will align all platforms. To properly support redirects consistently means we have to implement our own functionality and also tie that into the restricted networking settings. I believe this is out of scope for the SDK.

A custom HTTP implementation can be user-supplied via a HTTP resolver in the Context.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 6, 2026

Merging this PR will not alter performance

✅ 32 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing ok-nick/no-redirects (2b1061e) with main (e0e4cc2)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ok-nick
Copy link
Copy Markdown
Contributor Author

ok-nick commented Mar 11, 2026

TODO: Change behavior to only disable redirects if restricted networking is enabled after discussion with @gpeacock.

@ok-nick
Copy link
Copy Markdown
Contributor Author

ok-nick commented Apr 1, 2026

Redirects for the timestamp case will be fixed in #1855.

Comment thread sdk/src/crypto/time_stamp/provider.rs
Comment thread sdk/src/http/mod.rs
Comment thread sdk/src/identity/claim_aggregation/w3c_vc/did_web.rs
Comment thread sdk/src/settings/signer.rs
Comment thread sdk/src/context.rs
Comment thread sdk/src/http/mod.rs
@ok-nick ok-nick changed the title fix!: disable HTTP redirects in built-in networking implementation fix!: disable HTTP redirects in restricted networking implementation Apr 2, 2026
@ok-nick ok-nick merged commit fa6e690 into main Apr 2, 2026
26 checks passed
@ok-nick ok-nick deleted the ok-nick/no-redirects branch April 2, 2026 14:07
@caiopensrc caiopensrc mentioned this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants