feat: don't spawn threads when computing hashes in a zkVM#1945
Open
leruaa wants to merge 1 commit intocontentauth:mainfrom
Open
feat: don't spawn threads when computing hashes in a zkVM#1945leruaa wants to merge 1 commit intocontentauth:mainfrom
leruaa wants to merge 1 commit intocontentauth:mainfrom
Conversation
gpeacock
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Extend the WASM fallback path in
hash_stream_by_algto also apply when targeting azkvm. zkVM environments lack OS-level primitives like threading, so they require the same portable, sequential range-based read loop used for WASM.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.