Skip to content

fix(ga4): GA4 sidebar shows generic error for all customers [ES-433] #11065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tyler (tylerwashington888) merged 3 commits into from
Jul 10, 2026
+8 −9
Merged

fix(ga4): GA4 sidebar shows generic error for all customers [ES-433] #11065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51a7933
fix(ga4): use sdk.cma directly in Sidebar instead of useCMA [AIS-59]
tylerwashington888 Jul 10, 2026
c72c7d3
fix(ga4): loosen ZRunReportData Zod schema for optional proto3 fields…
tylerwashington888 Jul 10, 2026
2011feb
fix(ga4): remove inline comments from ZRunReportData schema
tylerwashington888 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions apps/google-analytics-4/frontend/src/apis/apiTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ export const ZRunReportData = z.object({
minimums: z.array(ZRow),
rowCount: z.number(),
metadata: z.object({
currencyCode: z.string(),
currencyCode: z.string().optional(),
dataLossFromOtherRow: z.boolean(),
timeZone: z.string(),
_currencyCode: z.string(),
_timeZone: z.string(),
timeZone: z.string().optional(),
_currencyCode: z.string().optional(),
_timeZone: z.string().optional(),
}),
propertyQuota: z.null(),
propertyQuota: z.unknown(),
kind: z.string(),
});

Expand Down
7 changes: 3 additions & 4 deletions apps/google-analytics-4/frontend/src/locations/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import AnalyticsApp from 'components/main-app/AnalyticsApp/AnalyticsApp';
import { useCMA, useSDK } from '@contentful/react-apps-toolkit';
import { useSDK } from '@contentful/react-apps-toolkit';
import { SidebarExtensionSDK } from '@contentful/app-sdk';
import { useMemo } from 'react';
import { Skeleton } from '@contentful/f36-components';
Expand All @@ -13,7 +13,6 @@ import { contentfulContext } from 'helpers/contentfulContext';

const Sidebar = () => {
const sdk = useSDK<SidebarExtensionSDK>();
const cma = useCMA();
const installationParameters = sdk.parameters.installation as
| AppInstallationParameters
| undefined;
Expand All @@ -26,8 +25,8 @@ const Sidebar = () => {
(rule) => rule.contentTypeId === currentContentType
);
const api = useMemo(
() => new Api(contentfulContext(sdk), cma, serviceAccountKeyId),
[cma, sdk, serviceAccountKeyId]
() => new Api(contentfulContext(sdk), sdk.cma, serviceAccountKeyId),
[sdk, serviceAccountKeyId]
);

const hasInstallationParams = serviceAccountKeyId && propertyId;
Expand Down
Loading