This repository was archived by the owner on Jun 24, 2021. It is now read-only.
Model lists as Lists of NonNull elements#48
Open
Scott Talbot (cysp) wants to merge 1 commit intocontentful:masterfrom
Open
Model lists as Lists of NonNull elements#48Scott Talbot (cysp) wants to merge 1 commit intocontentful:masterfrom
Scott Talbot (cysp) wants to merge 1 commit intocontentful:masterfrom
Conversation
Scott Talbot (cysp)
force-pushed
the
feature/nonnull-list-elements
branch
from
b4e8448 to
f1f8fe3
Compare
Scott Talbot (cysp)
force-pushed
the
feature/nonnull-list-elements
branch
2 times, most recently
from
82b830a to
f1f8fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently, a field that is marked as a List is represented in the schema as a List of Nullable elements, but it seems that the elements themselves can be marked NonNull?
Concretely, this turns a list-of-strings field from
[String]to[String!], maintaining nullability of the overall value but marking each element of the array as not nullable.Developing against a schema with nullable list elements in a null-safe language (in this case Swift) is not much fun.☹️