Added support for nested global fields#230
Merged
sunil-lakshman merged 5 commits intofeature_nested_global_fieldfrom Jan 7, 2025
Merged
Added support for nested global fields#230sunil-lakshman merged 5 commits intofeature_nested_global_fieldfrom
sunil-lakshman merged 5 commits intofeature_nested_global_fieldfrom
Conversation
aman19K
reviewed
Dec 17, 2024
lib/stack/globalField/index.js
Outdated
Comment on lines
72
to
73
| * client.stack({ api_key: 'api_key'}).globalField('global_field_uid').updateNestedGlobalField(data, { headers: { api_version: '3.3' }}) | ||
| * .then((globalField) => { |
aman19K
reviewed
Dec 17, 2024
lib/stack/index.js
Outdated
Comment on lines
166
to
167
| * client.stack({ api_key: 'api_key'}).globalField({ api_version: '3.2' }).fetch() | ||
| * .then((globalField) => console.log(globalField)) |
Contributor
There was a problem hiding this comment.
@sunil-lakshman , We cannot call the fetch method without the uid. Right? I think the second example can be removed.
sunil-lakshman
requested review from
aman19K,
harshithad0703,
nadeem-cs and
netrajpatel
aman19K
approved these changes
Dec 17, 2024
Contributor
|
@sunil-lakshman , LGTM. |
sunil-lakshman
added a commit
that referenced
this pull request
Feb 3, 2025
* Added support for nested global fields (#230) * Added support for nested global fields * Added mock file * Fixed PR comments * Added released version and removed duplicate code * Update package-lock.json file * Commeneted nested global fields sanity testcases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.