Implemented preview token generation#350
Merged
sunil-lakshman merged 2 commits intodevelopmentfrom May 14, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements preview token generation for delivery tokens. Key changes include:
- Adding test assertions to verify that a preview_token is generated.
- Updating the delivery token creation logic in both the DeliveryToken class and the entity module to include support for preview tokens.
- Bumping the package version and updating the changelog accordingly.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/sanity-check/api/deliveryToken-test.js | Added assertions to verify preview_token is not null in delivery token responses. |
| package.json | Updated version number from 1.21.1 to 1.21.2. |
| lib/stack/deliveryToken/index.js | Modified the create function call to include create_with_preview_token flag. |
| lib/entity.js | Updated the create function to accept and merge a create_with_preview_token flag. |
| CHANGELOG.md | Documented the enhancement related to preview token generation. |
|
Coverage report for commit: 64c04eb Summary - Lines: 89.12% | Methods: 98.58% | Branches: 72.38%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
aman19K
reviewed
May 13, 2025
aman19K
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.