feat: waitlist via upload - #12
Merged
Merged
Conversation
The presign endpoint dropped the legacy identifier/kind fields in favor of separate owner and email, and now rejects unknown keys (.strict()). Update the client to match: thread the scanned target through as owner, rename identifier to email everywhere, and stop sending kind:'html'. Without this, uploads from a fresh binary would 400 against the updated contract. See contextbridge/patchwave#8 for the server-side change.
blimmer
changed the title
blimmer
marked this pull request as ready for review
May 26, 2026 16:51
jcarver989
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.1...v0.1.0) (2026-05-26) ### Features * add interactive prompts and report sharing ([#4](#4)) ([23e8543](23e8543)) * bootstrap repo ([57653df](57653df)) * CLI entrypoint and project docs ([073dccb](073dccb)) * core infrastructure — Context, IO, GitHub client, analytics ([edd14ac](edd14ac)) * data collectors and dependency-bump heuristics ([2ef4ad3](2ef4ad3)) * React report web UI and build script ([00dd2ec](00dd2ec)) * refocus the report on engineer toil and polish the UI ([#9](#9)) ([ae6853f](ae6853f)) * report aggregation, cost model, bundling, and HTML render ([376adb8](376adb8)) * waitlist via upload ([#12](#12)) ([b2050e3](b2050e3)) ### Bug Fixes * allow setting numberstepper directly ([367beb8](367beb8)) * double counting reviewers and mergers ([2cfa24e](2cfa24e)) * exclude bot actors from the cost table and forked repos from the analysis ([#10](#10)) ([7ce42f0](7ce42f0)) * improved sources ([#13](#13)) ([010a11a](010a11a)) * streamline CLI share prompts ([#11](#11)) ([066465c](066465c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: contextbridge-pr-automation[bot] <259134118+contextbridge-pr-automation[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The upload presign endpoint changed its contract in contextbridge/patchwave#8: it dropped the legacy
identifier/kindfields in favor of separateownerandemail, and now rejects unknown keys (.strict()). This updates the client to match — threading the scanned target through asowner, renamingidentifier→emailacross the share flow andUploader, and dropping thekind: 'html'field. Without it, uploads from a freshly built binary would 400 against the updated contract.Review focus
We deliberately did not extract a shared Zod schema across the two repos. The schema is five fields, the repos have no shared-package plumbing, and client-side runtime validation of a self-constructed body buys little — only a shared type would catch a server rename, and that's a compile-time concern. We accepted the manual sync here; flag it if you'd rather invest in a contract test or shared package now.
Commits
09a7c69— fix: send owner and email with report uploads