fix(report): clean up repo lists in the risk story - #19
Merged
Conversation
Every repo in scope shares the scan target's owner, so the prefix is noise in these bars. Strip it for the visible label via a new format/repo.ts helper; the full owner/name stays in the hover tooltip and the methodology appendix.
blimmer
marked this pull request as ready for review
May 27, 2026 17:53
blimmer
commented
May 27, 2026
| data-testid={riskStoryTestIds.disabledAlertsLink} | ||
| onClick={() => reveal('calculation')} | ||
| className="text-primary underline underline-offset-4" | ||
| > |
Contributor
Author
There was a problem hiding this comment.
footnote was weird - rendering in a table now
| @@ -112,22 +112,26 @@ describe('App report shell', () => { | |||
| expect(screen.getByTestId(riskStoryTestIds.severityBar)).toBeInTheDocument(); | |||
Contributor
Author
There was a problem hiding this comment.
for long org names, the repo list was not useful
blimmer
pushed a commit
that referenced
this pull request
May 27, 2026
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2026-05-27) ### Bug Fixes * **report:** clean up repo lists in the risk story ([#19](#19)) ([4d71a9e](4d71a9e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: contextbridge-pr-automation[bot] <259134118+contextbridge-pr-automation[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two presentation fixes for the generated report's risk story. The "repos without security alerts enabled" list is now a proper table (
ReposWithoutAlertsTable) instead of an inlineRepoListblob, and the top-repos-by-severity bars now render the bare repo name instead ofowner/name. In a single-org scan every row shares the same owner, so the prefix was pure noise — and it was eating the truncated label, hiding the part that actually identifies the repo. The fullowner/nameis still kept in the bar's hover tooltip and the methodology appendix table.Review focus
The layer choice for dropping the org prefix: it happens at display time via a new
format/repo.tshelper, not upstream inaggregate.ts. The aggregate contract deliberately flattens every repo reference to anowner/namestring, and the appendix table + tooltip still need the full path, so stripping in the data layer would have destroyed information and weakened the per-repo map key. Sanity-check that this is the right boundary.Commits
eb84da9— fix: better repos listd2356fb— fix(report): show bare repo name in top-repos-by-severity bars