Conversation
7105dbc to
d176624
Compare
|
@mapuri - basic structure looks right to me - thanks! Some comments:
|
There was a problem hiding this comment.
curious why warn here? if policies are not associated with the ctx, then it is ok right?
There was a problem hiding this comment.
this is just a log message for type assertion failure.
Yes, it is ok for no policies to be associated. If policies are not associated then we just set the map as empty on the next line so that it is not nil.
|
@jainvipin thanks for the review. I will update the documentation and test cases as well and push them in this PR. |
e5534df to
124246d
Compare
|
I have updated the policy related structure to be in line with the proposal here https://gist.github.com/jainvipin/8b1677f041534df576b2 PTAL when you get a chance. |
There was a problem hiding this comment.
can we incorporate direction and PeerGroupId to the code? Ref the updated doc in the link below...
483a48d to
d9c25e5
Compare
8399cb4 to
47346b8
Compare
…o daemon Also hooked container create handler to set the policies in container config. Signed-off-by: Madhav Puri <madhav.puri@gmail.com>
8d94690 to
bafd8e6
Compare
https://gist.github.com/jainvipin/8b1677f041534df576b2 Signed-off-by: Madhav Puri <madhav.puri@gmail.com>
This patch contains changes to:
docker inspect.Next steps:
contiv/policyenginerepo) that adheres to the updated interfaceNote: some of the changes are in vendor directory which implies this will possibly be merged as separate PRs in docker, if it get's accepted that is :).
/cc @shaleman @jainvipin @erikh @unclejack