Skip to content

Update dependencies and enhance type validation in session handling #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demmmmios wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update dependencies and enhance type validation in session handling #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fdfb85
Update dependencies and enhance type validation in session handling
May 29, 2026
c0cc4d7
Update package name in composer.json
May 29, 2026
66cab14
Downgrade PHP version requirement to >=8.3 in composer.json
May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "contributte/mcp",
"name": "demmmmios/mcp",
"description": "Doctrine DBAL for Nette Framework",
"keywords": [
"nette",
Expand All @@ -20,16 +20,16 @@
}
],
"require": {
"php": ">=8.4",
"php": ">=8.3",
"guzzlehttp/guzzle": "^7.10.0",
"psr/container": "^2.0.2",
"psr/cache": "^3.0.0",
"psr/simple-cache": "^3.0.0",
"mcp/sdk": "dev-main#369932378f7bcfa29a00efc1530b70c4d501a24b"
"mcp/sdk": "^0.5.0"
},
"require-dev": {
"ext-pdo": "*",
"contributte/phpstan": "^0.2.0",
"contributte/phpstan": "^0.3.0",
"contributte/qa": "^0.5.0",
"contributte/tester": "^0.5.0",
"mockery/mockery": "^1.6.12",
Expand Down
6 changes: 5 additions & 1 deletion src/DI/Helpers/BuilderMan.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ public function getServiceDefinitionsByTag(string $tag): array
$definitions = [];

foreach ($builder->findByTag($tag) as $serviceName => $tagValue) {
$definitions[(string) $tagValue] = $builder->getDefinition($serviceName);
if (!is_string($tagValue)) {
continue;
}

$definitions[$tagValue] = $builder->getDefinition($serviceName);
}

return $definitions;
Expand Down
7 changes: 4 additions & 3 deletions src/DI/McpExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Mcp\Server\Builder;
use Mcp\Server\Session\FileSessionStore;
use Mcp\Server\Session\InMemorySessionStore;
use Mcp\Server\Session\Psr16StoreSession;
use Mcp\Server\Session\Psr16SessionStore;
use Nette\Application\IPresenterFactory;
use Nette\DI\CompilerExtension;
use Nette\DI\Definitions\ServiceDefinition;
Expand Down Expand Up @@ -178,7 +178,8 @@ private function loadServerConfiguration(string $serverName, stdClass $serverCon
// Server:Session
switch ($serverConfig->session->type) {
case 'file':
$path = $serverConfig->session->path ?? (isset($builder->parameters['tempDir']) ? $builder->parameters['tempDir'] . '/mcp' : null);
$tempDir = $builder->parameters['tempDir'] ?? null;
$path = $serverConfig->session->path ?? (is_string($tempDir) ? $tempDir . '/mcp' : null);
if ($path === null) {
throw new LogicalException(
sprintf('Session path must be configured for file sessions (server "%s"). Either set session.path or ensure %%tempDir%% is available.', $serverName)
Expand All @@ -198,7 +199,7 @@ private function loadServerConfiguration(string $serverName, stdClass $serverCon
}

$cacheService = BuilderMan::of($this)->resolveService($serverConfig->session->cache);
$sessionStore = new Statement(Psr16StoreSession::class, [$cacheService, $serverConfig->session->prefix, $serverConfig->session->ttl]);
$sessionStore = new Statement(Psr16SessionStore::class, [$cacheService, $serverConfig->session->prefix, $serverConfig->session->ttl]);
break;
default:
$sessionStore = null;
Expand Down
2 changes: 1 addition & 1 deletion src/Http/GuzzleBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static function fromNette(IRequest $netteRequest): ServerRequestInterface

$headers = [];
foreach ($netteRequest->getHeaders() as $name => $value) {
$headers[$name] = is_array($value) ? $value : [$value];
$headers[$name] = [$value];
}

$body = $netteRequest->getRawBody();
Expand Down