Skip NetteDatabaseTest when database connection unavailable#152
Merged
Conversation
Newer nette/tester reports "forgets to execute an assertion" when all test methods are skipped only via setUp's $this->skip(), because that path does not disable the assertion-count check. Skip at file level via Tester\Environment::skip() when MySQL is unreachable instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a database connectivity check to the NetteDatabaseTest to gracefully skip the test suite when the database is not available, rather than failing with connection errors.
Key changes:
use Tester\Environment;import to enable test skipping functionalityConnectionException, the test suite is skipped with an informative messageImplementation details:
https://claude.ai/code/session_01A8V5dTVDGP1CJTsjzfmosR