AWS: Parameter Store - Adds the ability to use secrets#3262
Open
benvinson-teespring wants to merge 1 commit intoconvox:masterfrom
Open
AWS: Parameter Store - Adds the ability to use secrets#3262benvinson-teespring wants to merge 1 commit intoconvox:masterfrom
benvinson-teespring wants to merge 1 commit intoconvox:masterfrom
Conversation
|
Why is this not merge yet? It would be great to have this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be able to leverage Parameter Store in Systems Manager, the following must be added to the container definition in the taskdef (as in provider/aws/formation/service.json.tmpl):
Considering I have no experience in Go, I'm surprised I could get the tests to pass.