[WIP] To watch organizations - #45
Open
dchiji wants to merge 11 commits into
Open
Conversation
hogelog
reviewed
Jul 18, 2018
hogelog
left a comment
hogelog
left a comment
Contributor
There was a problem hiding this comment.
Direction of this PR is looks good to me.
| unhook_org!(octokit_client) | ||
| else | ||
| unhook_repo!(octokit_client) | ||
| end |
Contributor
There was a problem hiding this comment.
I think these branches (organization or repository) are less readable.
How about splitting it into Tokite::Repository and Tokite::Organization?
added 7 commits
July 18, 2018 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests to watch organization events.
It enable us to automatically watch new repositories under watched organizations.
By this PR, tokite behaves almost same as PR #44 without GitHub App.
Please review this. @cookpad/dev-infra