Skip to content
This repository was archived by the owner on Feb 18, 2020. It is now read-only.

feat: Add Pagination to list view#45

Open
Gregcop1 wants to merge 1 commit intocoopTilleuls:feature/pagination-31from
Gregcop1:feature/pagination-31
Open

feat: Add Pagination to list view#45
Gregcop1 wants to merge 1 commit intocoopTilleuls:feature/pagination-31from
Gregcop1:feature/pagination-31

Conversation

@Gregcop1
Copy link
Copy Markdown
Contributor

@Gregcop1 Gregcop1 commented Jul 13, 2016

Changes proposed in this pull request:

  • Add pagination component to list view

Make sure those checkboxes are checked if you want to be reviewed

  • Your branch should be mergeable on current master
  • Tests should pass
  • Linter should pass
  • Code coverage should stay higher than 90%
  • Squash your commits to one commit and follow those recommendations about writing good commit message

Fix #31

@Gregcop1 Gregcop1 added the RFR label Jul 13, 2016
@Gregcop1 Gregcop1 added this to the v0.3.0 milestone Jul 13, 2016
@Gregcop1 Gregcop1 force-pushed the feature/pagination-31 branch from c041b50 to c9b9b65 Compare July 13, 2016 00:15
@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling c9b9b65 on Gregcop1:feature/pagination-31 into * on coopTilleuls:feature/pagination-31*.

List: {
displayProperties: ['givenName', 'familyName', 'telephone']
displayProperties: ['givenName', 'familyName', 'telephone'],
itemsPerPageOptions: [5, 15, 100]
Copy link
Copy Markdown

@toofff toofff Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would not it be better [30, 50, 100] ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is just an example. In the future it will move into documentation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants