pass logdir path to support downstream logging#32
Merged
Priyank-Shethia3 merged 1 commit intocooperbench:mainfrom Feb 7, 2026
Merged
pass logdir path to support downstream logging#32Priyank-Shethia3 merged 1 commit intocooperbench:mainfrom
Priyank-Shethia3 merged 1 commit intocooperbench:mainfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional
log_dirparameter to agent runner interface to enable external agents to write output files to the correct location.Closes #
Changes
log_dir: str | Noneparameter toAgentRunnerProtocol inagents/__init__.pyexecute_coop()and_spawn_agent()inrunner/coop.pyto compute and pass log directory path based on run_name and featuresexecute_solo()and_spawn_solo_agent()inrunner/solo.pyto compute and pass log directory path based on run_name and featuresChecklist