Conversation
Ensure NES requests are only sent if the client is attached to the current buffer. Notify the LSP client with "textDocument/didShowInlineEdit" only when a suggestion is actually displayed.
There was a problem hiding this comment.
Pull request overview
This PR enhances the Next Edit Suggestion (NES) feature by adding two safety checks: ensuring LSP requests are only sent when the client is attached to the buffer, and only notifying the LSP client when a suggestion is actually displayed to the user.
Key changes:
- Add buffer attachment check before sending NES requests
- Make
_display_next_suggestionreturn a boolean indicating display success - Send
textDocument/didShowInlineEditnotification only when suggestion is displayed - Enable error notifications for better debugging
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lua/copilot-lsp/util.lua |
Removed unnecessary diagnostic suppression comment for type checking |
lua/copilot-lsp/nes/ui.lua |
Modified _display_next_suggestion to return boolean indicating whether suggestion was displayed |
lua/copilot-lsp/nes/init.lua |
Added buffer attachment check, enabled error notifications, and made LSP notification conditional on successful display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Hey random note 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure NES requests are only sent if the client is attached to the current buffer. Notify the LSP client with "textDocument/didShowInlineEdit" only when a suggestion is actually displayed.